guile-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: guile-clutter: fixing ClutterMargin special wrapper


From: Mark H Weaver
Subject: Re: guile-clutter: fixing ClutterMargin special wrapper
Date: Fri, 18 Apr 2014 18:34:40 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux)

Hi David,

David Pirotte <address@hidden> writes:
> From a8166f67bd752ff7c71af50b27cfc52b2de4fe37 Mon Sep 17 00:00:00 2001
> From: David PIROTTE <address@hidden>
> Date: Fri, 18 Apr 2014 16:24:43 -0300
> Subject: [PATCH] fixing ClutterMargin special wrapper

Rather:
scm_scm_to_clutter_margin: Use scm_to_double, not scm_to_uint8.

> * clutter/gnome/gw/clutter-support.c: scm_scm_to_clutter_margin to use

Rather:
* clutter/gnome/gw/clutter-support.c (scm_scm_to_clutter_margin): Use

>   scm_to_double (instead of scm_to_uint8) for all 4 ClutterMargin structure
>   elements.

Other than that, looks good to me.  Please push!

    Thanks,
      Mark


> ---
>  clutter/gnome/gw/clutter-support.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/clutter/gnome/gw/clutter-support.c 
> b/clutter/gnome/gw/clutter-support.c
> index 7650f9e..e895d1e 100644
> --- a/clutter/gnome/gw/clutter-support.c
> +++ b/clutter/gnome/gw/clutter-support.c
> @@ -147,10 +147,10 @@ scm_scm_to_clutter_margin (SCM scm)
>  {
>      ClutterMargin ret;
>      
> -    ret.left = scm_to_uint8 (scm_car (scm));
> -    ret.right = scm_to_uint8 (scm_cadr (scm));
> -    ret.top = scm_to_uint8 (scm_caddr (scm));
> -    ret.bottom = scm_to_uint8 (scm_cadddr (scm));
> +    ret.left = scm_to_double (scm_car (scm));
> +    ret.right = scm_to_double (scm_cadr (scm));
> +    ret.top = scm_to_double (scm_caddr (scm));
> +    ret.bottom = scm_to_double (scm_cadddr (scm));
>  
>      return clutter_margin_copy (&ret);
>  }



reply via email to

[Prev in Thread] Current Thread [Next in Thread]