[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Patchset related to array functions

From: Andy Wingo
Subject: Re: Patchset related to array functions
Date: Thu, 14 Jul 2016 11:46:06 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)

Thanks for the update.

On Tue 12 Jul 2016 19:16, Daniel Llorens <address@hidden> writes:

> Subject: [PATCH 01/12] Compile in C99 mode

This could be a good change but it is not the fastest path to patch
review :)  There are three considerations here:

  (1) Can we support C99 on all targets we care about?

  (2) Can we use C99 in our public interface, or just internally?  If we
      use it publically, what should we change?  No more scm_t_uint8 I
      hope, besides for back-compat?  This patch set does not have to
      include these changes, but we should have a plan.

  (3) Most importantly, what is the impact on inlining?  See the comment
      in __scm.h around line 165.

If you want your patch set to depend on C99 that's fine, but you have to
answer these questions first for the project as a whole and get some


reply via email to

[Prev in Thread] Current Thread [Next in Thread]