[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: c-api.test fails on MS-Windows due to non-portable quoting

From: Eli Zaretskii
Subject: Re: c-api.test fails on MS-Windows due to non-portable quoting
Date: Wed, 10 Aug 2016 17:26:15 +0300

> From: Mark H Weaver <address@hidden>
> Cc: Andy Wingo <address@hidden>,  address@hidden
> Date: Wed, 10 Aug 2016 02:24:56 -0400
> >>   (zero? (system* "egrep" "-q" string filename))
> >
> > For this to work, the Windows implementation of system* will need to
> > be augmented to quote characters special for the shell, because
> > (unlike execvp on Posix hosts) the arguments of spawnvp are eventually
> > concatenated into a single string that gets passed to the system API
> > which invokes programs.  If this is the way you are willing to solve
> > this, I will submit a patch to that effect.
> I think this is the approach we should take here.  In general, we prefer
> to use 'system*' over 'system' because it avoids having to worry about
> quoting issues on POSIX systems.  We should enable this to work properly
> on MinGW, and avoid a situation where users might be discouraged from
> using 'system*' for the sake of MinGW compatibility.
> What do you think?

If you suggest to do what I described above, then I obviously agree.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]