[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Add to the 2.1.x branch GUILE_SITE_CCACHE_DIR and GUILE_EXTE

From: Andy Wingo
Subject: Re: [PATCH] Add to the 2.1.x branch GUILE_SITE_CCACHE_DIR and GUILE_EXTENSION_DIR Autoconf macros along with needed siteccachdir entry in pkgconfig file
Date: Mon, 13 Mar 2017 13:46:46 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux)

On Sun 12 Mar 2017 10:38, Freja Nordsiek <address@hidden> writes:

> Guile provides the GUILE_SITE_DIR Autoconf macro for finding where a
> user should install scheme files, but there are no equivalent macros
> for the directories to put compiled go files and C extensions into.
> The patch adds the equivalent macros to do this for the 2.1.x branch
> (it might work as is for the 2.0.x branch but I haven't tested it),
> which are more or less copy-pastes of the GUILE_SITE_DIR macro.

The patch looks good.  WDYT though about instead extending
GUILE_SITE_DIR to search for the ccache dir and the extension dir and
AC_SUBST them?  It would be nice to avoid adding more ceremonial lines

(I really wish I hadn't named it "ccache"; oh well, too late in 2.1.x to

> GUILE_SITE_CCACHE_DIR does require an additional entry to be put into
> Guile's pkgconfig file, which I named siteccachedir to fit in with the
> rest. One major issue is that the GUILE_SITE_CCACHE_DIR macro will
> fail for any version of Guile that does not have the new entry in the
> pkgconfig file, which would be all 2.0.x and 2.1.x releases thus far.
> One way around it would be to instead of using pkgconfig for it would
> to instead use the following macro that uses the Guile interpreter
> itself to find the directory (this is more or less the version I use
> in one of my own projects).
>       AC_MSG_CHECKING([for Guile site-ccache directory])
>       GUILE_SITE_CCACHE=`$GUILE -c "(display (%site-ccache-dir))"`
>       if test $? != "0" -o "$GUILE_SITE_CCACHE" = ""; then
>         AC_MSG_FAILURE([siteccachedir not found])
>       fi
>      ])

A fallback sounds good.  In that case it would work fine with 2.0.  We
can add more paths to the pkg-config file as well, in parallel; it's
better for other build systems.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]