[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Add preliminary versions of the R7RS libraries along with do
Re: [PATCH] Add preliminary versions of the R7RS libraries along with documentation and tests
Sun, 28 May 2017 15:35:10 +0200
I went through the patch and cleaned up a lot of little things (line
length in documentation, two spaces between sentences in
documentation, trailing spaces, etc.), made a proper commit
comment/log, and replaced the very ugly bytevector output port hack
with a cleaner and simpler hack (just used string output ports with
get-output-bytevector reading the input with the ISO-8859-1 encoding
and then converting to a bytevector).
On Thu, Mar 9, 2017 at 10:13 PM, Freja Nordsiek <address@hidden> wrote:
> I've written preliminary versionf of all the R7RS libraries along with
> documentation and unit tests for most of the procedures I had to add
> (none for those that were re-exports/renames of existing procedures in
> Guile). Sorry for the bad timing (right before the 2.2 release).
> I was inspired by the work in the r7rs-wip branch
> (https://git.savannah.gnu.org/cgit/guile.git/log/?h=r7rs-wip). I
> figured it would be a lot of work to get that branch up to date since
> the last commit was in mid 2014, so I decided to write just the
> libraries themselves but not work on adding any of the R7RS syntax
> that hasn't already been added by others to the master branch. I wrote
> the libraries in pure scheme and did not modify any other scheme
> modules or C code to simplify inclusion (they won't have side effects
> on other modules or code). Note that I did grab Mark H Weaver's
> implementation of the load procedure/syntax. I didn't copy more code
> because I wanted to make adding this to Guile not dependent on any
> changes to the parts in C or other scheme modules (would have taken a
> long time to sort out which changes in r7rs-wip branch depend on such
> modifications and which do not).
> The tests for what I added check out and the documentation compiles to
> info and html (compiling texinfo to pdf is broken on my computer for
> all projects so I wasn't able to test that).
> Note, I was not able to make unit tests for load, include, and
> include-ci. file-error? and read-error? are not 100% reliable, and my
> implementation of the bytevector output ports is a bit of a hack job.
> Also, I did not update cond-expand or include the R7RS syntax for
> declaring libraries. Those things are still missing.
> Patch is rather large.
> Freja Nordsiek
Description: Text Data
- Re: [PATCH] Add preliminary versions of the R7RS libraries along with documentation and tests,
Freja Nordsiek <=