[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Add preliminary versions of the R7RS libraries along with do
Mark H Weaver
Re: [PATCH] Add preliminary versions of the R7RS libraries along with documentation and tests
Mon, 19 Jun 2017 02:03:13 -0400
Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux)
Freja Nordsiek <address@hidden> writes:
> Also, I found one error in the get-output-bytevector procedure in
> (scheme base), which was that the procedure discarded the bytes
> already written. get-output-bytevector is not supposed to be
> destructive to the bytes already written, but the R6RS output
> bytevector reading procedures are destructive. I made a patch with a
> very simple fix, which is to just write the bytes back.
Ah, good catch! I'd like to fix this in a different way though: instead
of removing the bytes and then adding them back, I'd prefer to modify
r6rs-ports.c to support this (read-only) operation directly.