Re: [PATCH] Add string-replace-substring to (ice-9 string-fun)

[David Pirotte]

Hi,

> > On 5 Jan 2020, at 13:12, Jan Nieuwenhuizen <address@hidden> wrote:
> > 
> > Andy Wingo writes:
> >   
> >> On Fri 20 Dec 2019 18:32, lloda <address@hidden> writes:
> >>   
> >>> This patch adds string-replace-substring that wingo posted to the
> >>> mailing list to (ice-9 strings). This is a commonly used function
> >>> and a good implementation isn't trivial, so I think it deserves
> >>> inclusion.  
> >> 
> >> I didn't know that this module existed :)  Sure, why not.  Please
> >> fix the commit message when you push.  
> > 
> > That's great!  This is one of the things that has always amazed and
> > annoyed me to be missing and I have written several half-baken
> > implementations of it when I needed something like it.
> > 
> > Would it be too much to ask for some documentation to go with it, so
> > that we will be able to find it?  
> 
> Sure, I'll include that in the fixed patch.

Fwiw, guix has a (different) implementation as well, I don't know which
is best, but I think it should be anmed string-replace-all

        http://git.savannah.gnu.org/cgit/guix.git/tree/guix/utils.scm

David.

pgpvAX7tNn_OI.pgp
Description: OpenPGP digital signature