[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/1] Support mkdtemp via mkdtemp! and scm_mkdtemp

From: Mike Gran
Subject: Re: [PATCH 1/1] Support mkdtemp via mkdtemp! and scm_mkdtemp
Date: Wed, 30 Dec 2020 00:41:22 -0800

On Tue, Dec 29, 2020 at 07:50:05PM -0600, Rob Browning wrote:
> * doc/ref/posix.texi: Document mkdtemp! and scm_mkdtemp.
> * libguile/filesys.c: (mkdtemp!, scm_mkdtemp): New functions.
> Signed-off-by: Rob Browning <>

Hi Rob,

Since mkdtemp already returns a string of the new directory name,
it might be more scheme-like to not modify the input string, and instead
just return the new directory name.

Also, I don't know how universal mkdtemp is. It does exist in Linux and
OpenBSD, but, I'm not sure about all platforms. So a configure check
might not be amiss.

I'll send a reworked patch for you to consider.

Mike Gran

reply via email to

[Prev in Thread] Current Thread [Next in Thread]