[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Add 'bytevector-slice'.

From: Ludovic Courtès
Subject: Re: [PATCH] Add 'bytevector-slice'.
Date: Sat, 14 Jan 2023 16:19:49 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)


I pushed the patch as commit e441c34f1666921f6b15597c1aa3a50596a129d7
with the following changes taking into account your comments:

  • adjusted copyright years;

  • removed comment about ‘SCM_F_BYTEVECTOR_CONTIGUOUS’ since it’s quite
    clear from the discussion in this thread that this flag is

  • added an overflow check for ‘c_offset + c_size’ and a corresponding
    test (really glad you reported this one!);

  • added another missing test that you mentioned.

I did not update the license header as you suggested, but I think we
should run a script on all the repo to homogenize those but it’s a bit
messy right now.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]