[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: GNU Guile 3.0.9rc1 available for testing!
From: |
Ludovic Courtès |
Subject: |
Re: GNU Guile 3.0.9rc1 available for testing! |
Date: |
Mon, 23 Jan 2023 11:48:11 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) |
Hi,
Greg Troxel <gdt@lexort.com> skribis:
> lloda <lloda@sarc.name> writes:
>
>> This looks like https://debbugs.gnu.org/60971
>> <https://debbugs.gnu.org/60971> on mac os.
>
> Yes, it does.
>
> My quick reaction is that if the POSIX-required macros operation on
> system types that might be struct, then faking up ints for testing is
> unsound.
>
> Maybe only do verify if guile has to define macros, and don't try to
> test the OS?
So something like the patch below?
Thanks,
Ludo’.
diff --git a/libguile/posix.c b/libguile/posix.c
index 74c743119..0b1fe2637 100644
--- a/libguile/posix.c
+++ b/libguile/posix.c
@@ -105,8 +105,8 @@
# else
# define W_EXITCODE(ret, sig) ((ret) << 8 | (sig))
# endif
-#endif
verify (WEXITSTATUS (W_EXITCODE (127, 0)) == 127);
+#endif
#include <signal.h>
Re: GNU Guile 3.0.9rc1 available for testing!, Greg Troxel, 2023/01/22
Re: GNU Guile 3.0.9rc1 available for testing!, Ludovic Courtès, 2023/01/23
Re: GNU Guile 3.0.9rc1 available for testing!, Greg Troxel, 2023/01/24