[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] test-system-cmds: use sh -c instead of guile -c

From: Omar Polo
Subject: Re: [PATCH] test-system-cmds: use sh -c instead of guile -c
Date: Mon, 30 Jan 2023 16:44:48 +0100
User-agent: mblaze/1.2

On 2023/01/28 17:43:42 +0200, Eli Zaretskii <> wrote:
> > Date: Sat, 28 Jan 2023 11:17:07 +0100
> > From: Omar Polo <>
> > 
> > I'm not sure this patch is palatable as-is, but I'm adding it to the
> > OpenBSD port to have less failures in the regress suite.
> > 
> > The main issue is that "guile" may not be available at test time for
> > various reasons.  (the install prefix is not in $PATH, the executable
> > may be renamed --program-suffix, etc...)
> the intent of the test is to test the just-produced Guile binary, so
> if that binary is not on PATH, the test suite should be fixed so that
> it is on PATH.

my understanding is that it's using the just-produced Guile binary and
testing wether `system' and `system*' are able spawn executables and
return their exit code.

Anyway, I have to apologise, I can't reproduce the issue anymore.  It
was probably something wrong while I was trying to understand

Consider the patch dropped, the test suite correctly sets up the $PATH
as the README describe.

Sorry for the noise.

Omar Polo


reply via email to

[Prev in Thread] Current Thread [Next in Thread]