[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3] docs/match: pattern matcher example makeover

From: Josselin Poiret
Subject: Re: [PATCH v3] docs/match: pattern matcher example makeover
Date: Fri, 03 Feb 2023 14:43:44 +0100

Hi Blake and David,

We were talking about this very node of the documentation yesterday with
Ludovic and zimoun, so here are my two cents. Rewriting this
introduction is a very good idea, the current one is pretty hard to get
into for novices.

David Pirotte <> writes:

> Not at all - and quite annoying. imo.
> So i'd 'vote' not to use them anywhere in the guile reference manual

I agree that it's not "idiomatic Guile" so should probably be left out.

Regarding the examples, I think the first one is nice but the next one
is too involved, using a named let which a lot of users might not know.
I'd suggest demonstrating each feature without any extra prerequisite,
to make it as accessible as possible.

The third example, introducing the ellipsis, uses 2 of them directly,
with one nested! It also doesn't explain what the pattern variables are
bound to when an ellipsis is involved. Also, the example data you're
matching on looks too intimidating, which could scare novice readers.

Josselin Poiret

reply via email to

[Prev in Thread] Current Thread [Next in Thread]