guix-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

11/13: gnu: kcrash: Work around race condition when starting Xvfb.


From: Mark H. Weaver
Subject: 11/13: gnu: kcrash: Work around race condition when starting Xvfb.
Date: Wed, 11 Jan 2017 16:25:11 +0000 (UTC)

mhw pushed a commit to branch master
in repository guix.

commit 9e485ffa1b90e90207f53fcf58f43e29b639f852
Author: Ludovic Court├Ęs <address@hidden>
Date:   Sat Jan 7 13:07:29 2017 +0100

    gnu: kcrash: Work around race condition when starting Xvfb.
    
    Sometimes tests would start running before Xvfb is listening.
    See <https://hydra.gnu.org/build/1750201>.
    
    * gnu/packages/kde-frameworks.scm (kcrash)[arguments]: In
    'start-xorg-server', add 'sleep' call after starting Xvfb.  Pass "Xvfb"
    to 'system' instead of its absolute file name.
---
 gnu/packages/kde-frameworks.scm |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index 94145fb..36c2851 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -1300,8 +1300,8 @@ integrated it into your application's other widgets.")
          (add-before 'check 'start-xorg-server
            (lambda* (#:key inputs #:allow-other-keys)
              ;; The test suite requires a running X server.
-             (system (string-append (assoc-ref inputs "xorg-server")
-                                    "/bin/Xvfb :1 &"))
+             (system "Xvfb :1 &")
+             (sleep 2)              ;XXX: give the server enough time to start
              (setenv "DISPLAY" ":1")
              #t)))))
     (home-page "https://community.kde.org/Frameworks";)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]