01/01: gnu: Syncthing: Fix a crash bug.

[Leo Famulari]

lfam pushed a commit to branch master
in repository guix.

commit fd115bee31d04f1277560b82bb982e6aa19fc977
Author: Leo Famulari <address@hidden>
Date:   Thu Jul 12 11:23:24 2018 -0400

    gnu: Syncthing: Fix a crash bug.
    
    * gnu/packages/patches/syncthing-fix-crash.patch: New file.
    * gnu/local.mk (dist_patch_DATA): Add it.
    * gnu/packages/syncthing.scm (syncthing)[source]: Use it.
---
 gnu/local.mk                                   |  1 +
 gnu/packages/patches/syncthing-fix-crash.patch | 72 ++++++++++++++++++++++++++
 gnu/packages/syncthing.scm                     |  2 +
 3 files changed, 75 insertions(+)

diff --git a/gnu/local.mk b/gnu/local.mk
index 8ec1f16..72a4892 100644
--- a/gnu/local.mk
+++ b/gnu/local.mk
@@ -1138,6 +1138,7 @@ dist_patch_DATA =                                         
\
   %D%/packages/patches/superlu-dist-scotchmetis.patch          \
   %D%/packages/patches/swish-e-search.patch                    \
   %D%/packages/patches/swish-e-format-security.patch           \
+  %D%/packages/patches/syncthing-fix-crash.patch               \
   %D%/packages/patches/synfigstudio-fix-ui-with-gtk3.patch     \
   %D%/packages/patches/t1lib-CVE-2010-2642.patch               \
   %D%/packages/patches/t1lib-CVE-2011-0764.patch               \
diff --git a/gnu/packages/patches/syncthing-fix-crash.patch 
b/gnu/packages/patches/syncthing-fix-crash.patch
new file mode 100644
index 0000000..d27e543
--- /dev/null
+++ b/gnu/packages/patches/syncthing-fix-crash.patch
@@ -0,0 +1,72 @@
+Avoid a crash:
+
+https://github.com/syncthing/syncthing/issues/5002
+
+Patch copied from upstream source repository:
+
+https://github.com/syncthing/syncthing/commit/35a75a95dc6383b2d73ab645f1407f7907ec1a2c
+
+From 35a75a95dc6383b2d73ab645f1407f7907ec1a2c Mon Sep 17 00:00:00 2001
+From: Jakob Borg <address@hidden>
+Date: Wed, 13 Jun 2018 19:07:52 +0200
+Subject: [PATCH] lib/model: Don't panic when rechecking file (fixes #5002)
+ (#5003)
+
+---
+ lib/model/model.go      |  2 +-
+ lib/model/model_test.go | 26 ++++++++++++++++++++++++++
+ 2 files changed, 27 insertions(+), 1 deletion(-)
+
+diff --git a/lib/model/model.go b/lib/model/model.go
+index 5a9146e0..302f06c5 100644
+--- a/lib/model/model.go
++++ b/lib/model/model.go
+@@ -1373,7 +1373,7 @@ func (m *Model) recheckFile(deviceID protocol.DeviceID, 
folderFs fs.Filesystem,
+               return
+       }
+ 
+-      if blockIndex > len(cf.Blocks) {
++      if blockIndex >= len(cf.Blocks) {
+               l.Debugf("%v recheckFile: %s: %q / %q i=%d: block index too 
far", m, deviceID, folder, name, blockIndex)
+               return
+       }
+diff --git a/lib/model/model_test.go b/lib/model/model_test.go
+index 295eafc1..456bbc4a 100644
+--- a/lib/model/model_test.go
++++ b/lib/model/model_test.go
+@@ -3608,6 +3608,32 @@ func TestIssue4903(t *testing.T) {
+       }
+ }
+ 
++func TestIssue5002(t *testing.T) {
++      // recheckFile should not panic when given an index equal to the number 
of blocks
++
++      db := db.OpenMemory()
++      m := NewModel(defaultCfgWrapper, protocol.LocalDeviceID, "syncthing", 
"dev", db, nil)
++      m.AddFolder(defaultFolderConfig)
++      m.StartFolder("default")
++
++      m.ServeBackground()
++      defer m.Stop()
++
++      if err := m.ScanFolder("default"); err != nil {
++              t.Error(err)
++      }
++
++      file, ok := m.CurrentFolderFile("default", "foo")
++      if !ok {
++              t.Fatal("test file should exist")
++      }
++      nBlocks := len(file.Blocks)
++
++      m.recheckFile(protocol.LocalDeviceID, defaultFolderConfig.Filesystem(), 
"default", "foo", nBlocks-1, []byte{1, 2, 3, 4})
++      m.recheckFile(protocol.LocalDeviceID, defaultFolderConfig.Filesystem(), 
"default", "foo", nBlocks, []byte{1, 2, 3, 4}) // panic
++      m.recheckFile(protocol.LocalDeviceID, defaultFolderConfig.Filesystem(), 
"default", "foo", nBlocks+1, []byte{1, 2, 3, 4})
++}
++
+ func addFakeConn(m *Model, dev protocol.DeviceID) *fakeConnection {
+       fc := &fakeConnection{id: dev, model: m}
+       m.AddConnection(fc, protocol.HelloResult{})
+-- 
+2.18.0
+
diff --git a/gnu/packages/syncthing.scm b/gnu/packages/syncthing.scm
index 14e83b5..4c0bcee 100644
--- a/gnu/packages/syncthing.scm
+++ b/gnu/packages/syncthing.scm
@@ -24,6 +24,7 @@
   #:use-module (guix download)
   #:use-module (guix git-download)
   #:use-module (guix licenses)
+  #:use-module (gnu packages)
   #:use-module (gnu packages golang))
 
 (define-public syncthing
@@ -35,6 +36,7 @@
               (uri (string-append "https://github.com/syncthing/syncthing";
                                   "/releases/download/v" version
                                   "/syncthing-source-v" version ".tar.gz"))
+              (patches (search-patches "syncthing-fix-crash.patch"))
               (sha256
                (base32
                 "0bxkm5jlj6l4gai23bg0y31brr80r9qllh1rdg29pahjn0c2b4ml"))