[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
03/03: services: wpa-supplicant: Extend to support configuration paramet
From: |
Marius Bakke |
Subject: |
03/03: services: wpa-supplicant: Extend to support configuration parameters. |
Date: |
Wed, 17 Oct 2018 14:35:19 -0400 (EDT) |
mbakke pushed a commit to branch master
in repository guix.
commit acce0a474c1493ab18912bc46285248e4ccb0314
Author: Marius Bakke <address@hidden>
Date: Mon Apr 9 01:04:10 2018 +0200
services: wpa-supplicant: Extend to support configuration parameters.
This allows using WPA Supplicant "standalone" without an additional
network manager. The default configuration is unchanged.
* gnu/services/networking.scm (<wpa-supplicant-configuration>): New record
type.
(wpa-supplicant-shepherd-service): Pass configuration records to the daemon.
(wpa-supplicant-service-type): Adjust accordingly.
* doc/guix.texi (Networking Services): Document the new service type.
---
doc/guix.texi | 35 +++++++++++++-----
gnu/services/networking.scm | 86 ++++++++++++++++++++++++++++++++++-----------
2 files changed, 91 insertions(+), 30 deletions(-)
diff --git a/doc/guix.texi b/doc/guix.texi
index 5ae8091..2cea52f 100644
--- a/doc/guix.texi
+++ b/doc/guix.texi
@@ -11737,18 +11737,35 @@ When true, enable connman's vpn plugin.
@defvr {Scheme Variable} wpa-supplicant-service-type
This is the service type to run @url{https://w1.fi/wpa_supplicant/,WPA
supplicant}, an authentication daemon required to authenticate against
-encrypted WiFi or ethernet networks. It is configured to listen for
-requests on D-Bus.
+encrypted WiFi or ethernet networks.
address@hidden defvr
-The value of this service is the @code{wpa-supplicant} package to use.
-Thus, it can be instantiated like this:
address@hidden {Data Type} wpa-supplicant-configuration
+Data type representing the configuration of WPA Supplicant.
address@hidden
-(use-modules (gnu services networking))
+It takes the following parameters:
-(service wpa-supplicant-service-type)
address@hidden lisp
address@hidden defvr
address@hidden @asis
address@hidden @code{wpa-supplicant} (default: @code{wpa-supplicant})
+The WPA Supplicant package to use.
+
address@hidden @code{dbus?} (default: @code{#t})
+Whether to listen for requests on D-Bus.
+
address@hidden @code{pid-file} (default: @code{"/var/run/wpa_supplicant.pid"})
+Where to store the PID file.
+
address@hidden @code{interface} (default: @code{#f})
+If this is set, it must specify the name of a network interface that
+WPA supplicant will control.
+
address@hidden @code{config-file} (default: @code{#f})
+Optional configuration file to use.
+
address@hidden @code{extra-options} (default: @code{'()})
+List of additional command-line arguments to pass to the daemon.
address@hidden table
address@hidden deftp
@cindex iptables
@defvr {Scheme Variable} iptables-service-type
diff --git a/gnu/services/networking.scm b/gnu/services/networking.scm
index 3fdb2bb..c809b4a 100644
--- a/gnu/services/networking.scm
+++ b/gnu/services/networking.scm
@@ -5,7 +5,7 @@
;;; Copyright © 2016 John Darrington <address@hidden>
;;; Copyright © 2017 Clément Lassieur <address@hidden>
;;; Copyright © 2017 Thomas Danckaert <address@hidden>
-;;; Copyright © 2017 Marius Bakke <address@hidden>
+;;; Copyright © 2017, 2018 Marius Bakke <address@hidden>
;;; Copyright © 2018 Tobias Geerinckx-Rice <address@hidden>
;;; Copyright © 2018 Chris Marusich <address@hidden>
;;; Copyright © 2018 Arun Isaac <address@hidden>
@@ -101,6 +101,16 @@
modem-manager-configuration
modem-manager-configuration?
modem-manager-service-type
+
+ <wpa-supplicant-configuration>
+ wpa-supplicant-configuration
+ wpa-supplicant-configuration?
+ wpa-supplicant-configuration-wpa-supplicant
+ wpa-supplicant-configuration-pid-file
+ wpa-supplicant-configuration-dbus?
+ wpa-supplicant-configuration-interface
+ wpa-supplicant-configuration-config-file
+ wpa-supplicant-configuration-extra-options
wpa-supplicant-service-type
openvswitch-service-type
@@ -1019,28 +1029,62 @@ networking."))))
;;; WPA supplicant
;;;
-
-(define (wpa-supplicant-shepherd-service wpa-supplicant)
- "Return a shepherd service for wpa_supplicant"
- (list (shepherd-service
- (documentation "Run WPA supplicant with dbus interface")
- (provision '(wpa-supplicant))
- (requirement '(user-processes dbus-system loopback))
- (start #~(make-forkexec-constructor
- (list (string-append #$wpa-supplicant
- "/sbin/wpa_supplicant")
- "-u" "-B" "-P/var/run/wpa_supplicant.pid")
- #:pid-file "/var/run/wpa_supplicant.pid"))
- (stop #~(make-kill-destructor)))))
+(define-record-type* <wpa-supplicant-configuration>
+ wpa-supplicant-configuration make-wpa-supplicant-configuration
+ wpa-supplicant-configuration?
+ (wpa-supplicant wpa-supplicant-configuration-wpa-supplicant ;<package>
+ (default wpa-supplicant))
+ (pid-file wpa-supplicant-configuration-pid-file ;string
+ (default "/var/run/wpa_supplicant.pid"))
+ (dbus? wpa-supplicant-configuration-dbus? ;Boolean
+ (default #t))
+ (interface wpa-supplicant-configuration-interface ;#f | string
+ (default #f))
+ (config-file wpa-supplicant-configuration-config-file ;#f |
<file-like>
+ (default #f))
+ (extra-options wpa-supplicant-configuration-extra-options ;list of
strings
+ (default '())))
+
+(define wpa-supplicant-shepherd-service
+ (match-lambda
+ (($ <wpa-supplicant-configuration> wpa-supplicant pid-file dbus? interface
+ config-file extra-options)
+ (list (shepherd-service
+ (documentation "Run the WPA supplicant daemon")
+ (provision '(wpa-supplicant))
+ (requirement '(user-processes dbus-system loopback))
+ (start #~(make-forkexec-constructor
+ (list (string-append #$wpa-supplicant
+ "/sbin/wpa_supplicant")
+ (string-append "-P" #$pid-file)
+ "-B" ;run in background
+ #$@(if dbus?
+ #~("-u")
+ #~())
+ #$@(if interface
+ #~(string-append "-i" #$interface)
+ #~())
+ #$@(if config-file
+ #~(string-append "-c" #$config-file)
+ #~())
+ address@hidden)
+ #:pid-file #$pid-file))
+ (stop #~(make-kill-destructor)))))))
(define wpa-supplicant-service-type
- (service-type (name 'wpa-supplicant)
- (extensions
- (list (service-extension shepherd-root-service-type
- wpa-supplicant-shepherd-service)
- (service-extension dbus-root-service-type list)
- (service-extension profile-service-type list)))
- (default-value wpa-supplicant)))
+ (let ((config->package
+ (match-lambda
+ (($ <wpa-supplicant-configuration> wpa-supplicant)
+ (list wpa-supplicant)))))
+ (service-type (name 'wpa-supplicant)
+ (extensions
+ (list (service-extension shepherd-root-service-type
+ wpa-supplicant-shepherd-service)
+ (service-extension dbus-root-service-type
config->package)
+ (service-extension profile-service-type
config->package)))
+ (description "Run the WPA Supplicant daemon, a service that
+implements authentication, key negotiation and more for wireless networks.")
+ (default-value (wpa-supplicant-configuration)))))
;;;