[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
09/09: Fix lint checker tests
From: |
Christopher Baines |
Subject: |
09/09: Fix lint checker tests |
Date: |
Sun, 7 Jun 2020 16:28:00 -0400 (EDT) |
cbaines pushed a commit to branch master
in repository data-service.
commit 480d718fa8a6d8e5b4e84703b5ca84669bb8a38f
Author: Danjela Lura <danielaluraa@gmail.com>
AuthorDate: Sat Jun 6 18:20:14 2020 +0200
Fix lint checker tests
Signed-off-by: Christopher Baines <mail@cbaines.net>
---
guix-data-service/model/lint-checker.scm | 3 ++-
tests/model-lint-checker.scm | 16 ++++++++++++----
2 files changed, 14 insertions(+), 5 deletions(-)
diff --git a/guix-data-service/model/lint-checker.scm
b/guix-data-service/model/lint-checker.scm
index 133984d..6603bbb 100644
--- a/guix-data-service/model/lint-checker.scm
+++ b/guix-data-service/model/lint-checker.scm
@@ -24,7 +24,8 @@
lint-warning-count-by-lint-checker-for-revision
insert-guix-revision-lint-checkers
lint-checkers-for-revision
- lint-checker-description-data->lint-checker-description-set-id))
+ lint-checker-description-data->lint-checker-description-set-id
+ insert-lint-checker-description-set))
(define (lint-checkers->lint-checker-ids conn lint-checkers-data)
(insert-missing-data-and-return-all-ids
diff --git a/tests/model-lint-checker.scm b/tests/model-lint-checker.scm
index 18679cc..e6740b1 100644
--- a/tests/model-lint-checker.scm
+++ b/tests/model-lint-checker.scm
@@ -6,10 +6,6 @@
(test-begin "test-model-lint-checker")
-(define data
- '((name-1 "description-1" #t)
- (name-2 "description-2" #f)))
-
(with-postgresql-connection
"test-model-lint-checker"
(lambda (conn)
@@ -19,6 +15,12 @@
(with-postgresql-transaction
conn
(lambda (conn)
+ (define data
+ `((name-1 #t ,(string->number (insert-lint-checker-description-set
+ conn '(37))))
+ (name-2 #f ,(string->number (insert-lint-checker-description-set
+ conn '(38))))))
+
(match (lint-checkers->lint-checker-ids conn data)
(((? number? id1) (? number? id2))
#t)))
@@ -28,6 +30,12 @@
(with-postgresql-transaction
conn
(lambda (conn)
+ (define data
+ `((name-1 #t ,(string->number (insert-lint-checker-description-set
+ conn '(37))))
+ (name-2 #f ,(string->number (insert-lint-checker-description-set
+ conn '(38))))))
+
(match (lint-checkers->lint-checker-ids conn data)
(((? number? id1) (? number? id2))
(match (lint-checkers->lint-checker-ids conn data)
- branch master updated (ae6541a -> 480d718), Christopher Baines, 2020/06/07
- 01/09: Get the translated lint checker descriptions into the database, Christopher Baines, 2020/06/07
- 02/09: Add checks to guard against null data, Christopher Baines, 2020/06/07
- 05/09: Make the form-horizontal-control procedure aware of hidden inputs, Christopher Baines, 2020/06/07
- 04/09: Make the query that provides locale options look nicer, Christopher Baines, 2020/06/07
- 07/09: Fall back to en_US.utf8 for the lint warnings page for a revision, Christopher Baines, 2020/06/07
- 09/09: Fix lint checker tests,
Christopher Baines <=
- 03/09: Use lint checker related translations on some pages, Christopher Baines, 2020/06/07
- 06/09: Provide the comparison page with translated lint warnings, Christopher Baines, 2020/06/07
- 08/09: Fall back to en_US.utf8 in the package page, Christopher Baines, 2020/06/07