guix-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

01/02: build: image: Do not call make-essential-device-nodes by default.


From: guix-commits
Subject: 01/02: build: image: Do not call make-essential-device-nodes by default.
Date: Tue, 9 Jun 2020 04:32:44 -0400 (EDT)

mothacehe pushed a commit to branch master
in repository guix.

commit 8423c2d3097da2d9d25b6f56c1971ac7147d3ad9
Author: Mathieu Othacehe <othacehe@gnu.org>
AuthorDate: Tue Jun 9 10:23:15 2020 +0200

    build: image: Do not call make-essential-device-nodes by default.
    
    Calling "mknod" without root permissions fails. Plus those device nodes do 
not
    appear to be needed to boot.
    
    * gnu/build/image.scm (initialize-root-partition): Do not use
    make-essential-device-nodes as default make-device-nodes procedure.
---
 gnu/build/image.scm | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/gnu/build/image.scm b/gnu/build/image.scm
index fb85bd4..893b846 100644
--- a/gnu/build/image.scm
+++ b/gnu/build/image.scm
@@ -161,8 +161,7 @@ deduplicates files common to CLOSURE and the rest of 
PREFIX."
                                     references-graphs
                                     (register-closures? #t)
                                     system-directory
-                                    (make-device-nodes
-                                     make-essential-device-nodes)
+                                    make-device-nodes
                                     #:allow-other-keys)
   "Initialize the given ROOT directory. Use BOOTCFG and BOOTCFG-LOCATION to
 install the bootloader configuration.
@@ -175,7 +174,8 @@ of the directory of the 'system' derivation."
   (populate-store references-graphs root)
 
   ;; Populate /dev.
-  (make-device-nodes root)
+  (when make-device-nodes
+    (make-device-nodes root))
 
   (when register-closures?
     (for-each (lambda (closure)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]