[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
06/11: Clarify that the derivations comparison only is for packages
From: |
Christopher Baines |
Subject: |
06/11: Clarify that the derivations comparison only is for packages |
Date: |
Fri, 9 Oct 2020 15:21:20 -0400 (EDT) |
cbaines pushed a commit to branch master
in repository data-service.
commit 51204aefca14a0eb6777f9fb6ee676675c41c49b
Author: Christopher Baines <mail@cbaines.net>
AuthorDate: Fri Oct 9 19:31:21 2020 +0100
Clarify that the derivations comparison only is for packages
As it excludes the channel instances and system tests.
---
guix-data-service/web/compare/controller.scm | 8 ++++----
guix-data-service/web/compare/html.scm | 4 ++--
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/guix-data-service/web/compare/controller.scm
b/guix-data-service/web/compare/controller.scm
index 07b03be..6d7e78b 100644
--- a/guix-data-service/web/compare/controller.scm
+++ b/guix-data-service/web/compare/controller.scm
@@ -101,7 +101,7 @@
(target_derivation ,parse-derivation #:required)))))
(render-compare/derivation mime-types
parsed-query-parameters)))
- (('GET "compare" "derivations")
+ (('GET "compare" "package-derivations")
(let* ((parsed-query-parameters
(parse-query-parameters
request
@@ -110,8 +110,8 @@
(system ,parse-system #:multi-value)
(target ,parse-target #:multi-value)
(build_status ,parse-build-status #:multi-value)))))
- (render-compare/derivations mime-types
- parsed-query-parameters)))
+ (render-compare/package-derivations mime-types
+ parsed-query-parameters)))
(('GET "compare-by-datetime" "derivations")
(let* ((parsed-query-parameters
(guard-against-mutually-exclusive-query-parameters
@@ -499,7 +499,7 @@
data)
#:extra-headers http-headers-for-unchanging-content)))))))
-(define (render-compare/derivations mime-types
+(define (render-compare/package-derivations mime-types
query-parameters)
(define (derivations->alist derivations)
(map (match-lambda
diff --git a/guix-data-service/web/compare/html.scm
b/guix-data-service/web/compare/html.scm
index 8b35290..684ca7e 100644
--- a/guix-data-service/web/compare/html.scm
+++ b/guix-data-service/web/compare/html.scm
@@ -84,8 +84,8 @@
(href ,(string-append "/compare/packages" query-params)))
"Compare packages")
(a (@ (class "btn btn-default")
- (href ,(string-append "/compare/derivations" query-params)))
- "Compare derivations"))))
+ (href ,(string-append "/compare/package-derivations"
query-params)))
+ "Compare package derivations"))))
(div
(@ (class "row"))
- branch master updated (f1eb2d3 -> 4f3be14), Christopher Baines, 2020/10/09
- 01/11: Guard against derivation IDs that aren't numbers, Christopher Baines, 2020/10/09
- 02/11: Guard against errors when recording job stderr output, Christopher Baines, 2020/10/09
- 04/11: Change the derivation comparison targets, Christopher Baines, 2020/10/09
- 03/11: Link to the revisions in the comparison header, Christopher Baines, 2020/10/09
- 05/11: Use letpar& for systems and targets in render-compare/derivations, Christopher Baines, 2020/10/09
- 06/11: Clarify that the derivations comparison only is for packages,
Christopher Baines <=
- 08/11: Include tablespace as a label for table metrics, Christopher Baines, 2020/10/09
- 09/11: Include the base commit and target commit in the compare output, Christopher Baines, 2020/10/09
- 07/11: Improve select-job-for-commit, Christopher Baines, 2020/10/09
- 10/11: Add Prometheus metrics for indexes specifically, Christopher Baines, 2020/10/09
- 11/11: Split the jobs metric in to succeede, queued and failed, Christopher Baines, 2020/10/09