Re: [PATCH 1/2] gnu: Add datefudge.

[Cyril Roelandt]

On 08/16/2013 07:45 PM, Ludovic Courtès wrote:
> Cyril Roelandt <address@hidden> skribis:
>
> > +        (alist-replace
> > +         'configure
> > +         (lambda* (#:key version outputs #:allow-other-keys #:rest args)
> > +          (pk version outputs)
>
> Leftover debugging statements, and ‘version’ doesn’t exist.
>
> What you can do is use:
>
>    (arguments
>      `( ...
>         ,version
>         ...
>        ))
>
> to paste the ‘version’ field of the package being defined in the
> quasiquote expression.

What kind of whitchcraft is this ? This works but I have no idea why. I 
don't think that Duckduckgoing "GNU Guile ," will give me any 
interesting results, so would you care to explain how this works, or 
redirect me to the appropriate documentation ?


> > +           (substitute* "Makefile"
> > +             (("^VERSION.*$") (string-append "VERSION=" version)))
> > +           ;; We do not need to pass these flags to "install".
> > +           (substitute* "Makefile"
>
> No need to repeat ‘substitute*’: there can be several substitutations in
> a substitute* form.
>
> > +           (substitute* "Makefile"
> > +             (("^prefix.*$") (string-append "prefix=" out "\n")))))
>
> Ditto.

OK.

> > +    (inputs `(("perl" ,perl))) ; Needed for the tests.
>
> ‘native-inputs’, probably (if it were being cross-compiled, you’d want
> to run the native Perl, right?).

Not sure about the difference between inputs and native-inputs. I think 
we may want to improve the documentation:

$ git grep native-inputs doc/
$


Cyril.