[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Add libtheora package
|
From: |
Andreas Enge |
|
Subject: |
Re: [PATCH] Add libtheora package |
|
Date: |
Mon, 14 Oct 2013 11:23:32 +0200 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Sun, Oct 13, 2013 at 07:20:59PM -0400, David Thompson wrote:
> How does it look?
It compiles well and looks good, congratulations! One point, though:
If you do
cd /nix/store/f06apny3g77kjk0wxzhmgl4b3ya77f0b-libtheora-1.1.1/lib/pkgconfig/
grep Requires *.pc
you only see ogg, not vorbis.
So I think you can move libvorbis from propagated-inputs into regular inputs.
At a later point, you might wish to add libsdl as an input (I think you were
working on it already.)
Andreas