[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] gnu: Add IceCat.

From: Ludovic Courtès
Subject: Re: [PATCH] gnu: Add IceCat.
Date: Mon, 11 Nov 2013 22:34:36 +0100
User-agent: Gnus/5.130007 (Ma Gnus v0.7) Emacs/24.3 (gnu/linux)

Andreas Enge <address@hidden> skribis:

> See the attached patch. Comments welcome. Do I miss any interesting inputs?


> +(define-public icecat
> +  (package
> +    (name "icecat")
> +    (version "24.0")
> +    (source
> +     (origin
> +      (method url-fetch)
> +      (uri (string-append "mirror://gnu/gnuzilla/"
> +                          (string-copy version 0 (string-index version #\.))

Perhaps ‘substring’ instead of ‘string-copy’ (does pretty much the same
thing, but the meaning is clearer IMO.)

> +          (lambda* (#:key #:allow-other-keys)

(lambda _ ...) is enough (where ‘_’ is a convention to suggest that we
don’t care about the arguments.)

> +            ;; delete dangling symlinks

Do they cause problem with one of the patch-everything passes?

Other than that, it looks good to me.

Thanks for this brave endeavor!


reply via email to

[Prev in Thread] Current Thread [Next in Thread]