[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] gnu: packages: Add ncdc-1.18.1.

From: Ludovic Courtès
Subject: Re: [PATCH] gnu: packages: Add ncdc-1.18.1.
Date: Fri, 24 Jan 2014 18:18:26 +0100
User-agent: Gnus/5.130007 (Ma Gnus v0.7) Emacs/24.3 (gnu/linux)

Overall looks good to me.  Could you send an updated version that fixes
the details below?

Sree Harsha Totakura <address@hidden> skribis:

> * gnu/packages/: Add new file dc.scm.
> * Add file dc.scm.
> * gnu/packages/dc.scm: Recipe for ncdc-1.18.1.

Please use the same format we normally use (see ‘git log’ for examples.)

> +  #:use-module ((guix licenses)
> +                #:renamer (symbol-prefix-proc 'license:)))

  #:use-module (guix licenses)

> +    (synopsis 
> +     "moder and lightweight direct connect client with a friendly ncurses
> +interface")

Could you start with a capital letter, and make it fit and one line?

> +    (description
> +     "Ncdc is a Direct Connect protocol client implemented using ncurses 
> known

Perhaps something like: “is a client for the Direct Connect peer-to-peer
file sharing protocol” (yeah I just discovered what Direct Connect is,
so thanks ;-)).

> +    (license 'license:x11)))
There should be no quote here.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]