guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] gnu: ratpoison: Patch to use $SHELL instead of /bin/sh


From: Ludovic Courtès
Subject: Re: [PATCH] gnu: ratpoison: Patch to use $SHELL instead of /bin/sh
Date: Thu, 13 Feb 2014 14:08:02 +0100
User-agent: Gnus/5.130007 (Ma Gnus v0.7) Emacs/24.3 (gnu/linux)

Andreas Enge <address@hidden> skribis:

> On Thu, Feb 13, 2014 at 01:28:25AM -0500, Mark H Weaver wrote:
>> I'm not entirely sure this will be wanted, but it bugged me that
>> ratpoison has /bin/sh hardcoded in its source code.  WDYT?
>
> Should it be replaced by the user $SHELL or by (which "bash")?

I think it’s OK to not use (which "bash") here, because it doesn’t
affect core functionality.

The patch looks good to me; OK to push.

An alternative way to do it would be to have a Ratpoison variable for
the shell to use.  That’s something that could be accepted upstream I
suppose.

Thanks,
Ludo’.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]