[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: dmd: [PATCH] Improve socket connection errors handling.

From: Cyprien Nicolas
Subject: Re: dmd: [PATCH] Improve socket connection errors handling.
Date: Thu, 10 Apr 2014 17:16:18 +0200
User-agent: Mutt/1.5.21 (2010-09-15)

Il y a environ 24 minutes, Ludovic Courtès écrivit :
> I pushed a couple of patches that achieve the same result slightly
> differently: ‘open-connection’ is left unchanged and it’s the caller’s
> responsibility to handle any errors; clients use the new
> ‘with-system-error-handling’ macro do handle all ‘system-error’
> exceptions gracefully.

Right, much better and elegant fix :-)

> One remark:
> > +        (lambda (key . args)
> > +          (display (format #f "Error: Cannot connect to socket `~a': ~a\n"
> > +                           file (apply format #f (cadr args) (caddr args)))
> > +                   (current-error-port))
> This could be directly (format (current-error-port) ...).

I missed that part of the documentation.  Thanks for pointing
that out.

> Also, we avoid uses of ‘car’, ‘cadr’ etc. in favor of ‘match’ (at least
> in new code.)

Noted, thanks.


Attachment: signature.asc
Description: Digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]