[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Everything depends on openmpi

From: Ludovic Courtès
Subject: Re: Everything depends on openmpi
Date: Fri, 09 May 2014 23:09:23 +0200
User-agent: Gnus/5.130009 (Ma Gnus v0.9) Emacs/24.3 (gnu/linux)

Thanks Eric for addressing the issue.

Commit e5c66f8 does:

+(define-public fftw-openmpi
+  (package (inherit fftw)
+    (name "fftw-openmpi")
+    (inputs
+     `(("openmpi" ,openmpi)
+       ,@(package-inputs fftw)))
+    (arguments
+     (substitute-keyword-arguments (package-arguments fftw)
+       ((#:configure-flags cf)
+        `(cons "--enable-mpi" ,cf))))
+    (description
+     (string-append (package-description fftw)
+                    "  With OpenMPI parallelism support."))))

I don’t think I’ve mentioned it before, but we should refrain from using
‘string-append’ in descriptions, because that prevents i18n (xgettext
won’t catch it.)

Instead, I’d suggest leaving ‘description’ unchanged, and writing
‘synposis’ in full, with “(with MPI support)” added at the end.
See ‘unionfs-fuse/static’ for an example.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]