[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/4] gnu: openmpi: Add memchecker support

From: Ludovic Courtès
Subject: Re: [PATCH 1/4] gnu: openmpi: Add memchecker support
Date: Sun, 18 May 2014 12:06:03 +0200
User-agent: Gnus/5.130009 (Ma Gnus v0.9) Emacs/24.3 (gnu/linux)

Eric Bavier <address@hidden> skribis:

> Ludovic Courtès writes:
>> Eric Bavier <address@hidden> skribis:
>>> From 3aaab98e3b9a0b1b893dd5bc64e098136364e717 Mon Sep 17 00:00:00 2001
>>> From: Eric Bavier <address@hidden>
>>> Date: Sat, 17 May 2014 00:02:44 -0500
>>> Subject: [PATCH 1/4] gnu: openmpi: Add memchecker support
>>> * gnu/packages/mpi.scm (openmpi) [inputs]: Add valgrind.
>>>   [arguments]: Add configure flags for memchecker.
>> [...]
>>>      (native-inputs
>>>       `(("pkg-config" ,pkg-config)))
>>>      (propagated-inputs
>>> -     `(("gfortran" ,gfortran-4.8)))
>>> +     `(("gfortran" ,gfortran-4.8)
>>> +       ("valgrind" ,valgrind)))
>> Why is Valgrind propagated?  I would expect it to be used only in
>> OpenMPI’s test suite, no?
> The intention of OpenMPI's memchecker option is to allow one to more
> easily use valgrind when executing mpi programs.  That being said, it is
> an optional feature, so it may not need to be propagated.  I'll look at
> that again.

But that still makes Valgrind optional when using Open MPI, no?  I would
not propagate it if it’s optional.

>> (I also wonder why GFortran is propagated, probably overlooked it
>> before.)
> GFortran needs to be propagated for the OpenMPI compiler wrappers.

OK.  I would not propagate it either because, suppose you just want to
use the library in a C program, then it doesn’t make sense to pull the
Fortran compiler.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]