[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] gnu: Add cssc.

From: Ludovic Courtès
Subject: Re: [PATCH] gnu: Add cssc.
Date: Tue, 27 May 2014 23:13:38 +0200
User-agent: Gnus/5.130009 (Ma Gnus v0.9) Emacs/24.3 (gnu/linux)

John Darrington <address@hidden> skribis:

> * gnu/packages/version-control.scm (cssc): New variable.
> * gnu/packages/patches/cssc-gets-undeclared.patch: New file
> * gnu/packages/patches/cssc-missing-include.patch: New file

Please add the patches to  Also, make sure that each one
starts with one line describing what it does and whether it’s fixed

> +                     ;; This test has no hope of passing until there is a 
> "nogroup"
> +                     ;; entry (or at least some group to which the guix 
> builder does
> +                     ;; not belong) in the /etc/group file of the build 
> environment.
> +                     ;; Currently we do not have such a group.  This test is 
> therefore
> +                     ;; destined to fail.
> +                     (substitute* "tests/Makefile"
> +                       (("test-delta ") ""))))

Please mark the comment as “XXX:”, and perhaps change the last sentence
to (say) “Thus, disable this test for now.”



reply via email to

[Prev in Thread] Current Thread [Next in Thread]