[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] gnu: Add guile-opengl

From: Ludovic Courtès
Subject: Re: [PATCH] gnu: Add guile-opengl
Date: Wed, 25 Jun 2014 21:29:19 +0200
User-agent: Gnus/5.130009 (Ma Gnus v0.9) Emacs/24.3 (gnu/linux)

David Thompson <address@hidden> skribis:

> Finally got around to finishing up this package.  I ran the example
> programs shipped with guile-opengl and confirmed that they work as
> expected. :)
> How does it look?

Looks good to me!  One comment:

> +                   (define (dynamic-link-substitute file lib input)
> +                     (substitute* file
> +                       (((string-append "dynamic-link \"" lib "\""))
> +                        (string-append "dynamic-link \""
> +                                       (assoc-ref inputs input)
> +                                       "/lib/" lib "\""))))

Patterns in ‘substitute*’ are supposed to be literals.

Wouldn’t it work to do something like:

  (substitute* file
    (("dynamic-link \"lib[a-zA-Z]+\" _ libname)
     (string-append ...)))



reply via email to

[Prev in Thread] Current Thread [Next in Thread]