[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 1/2] guix ui: add the "depends" field to package->recutils
Re: [PATCH v3 1/2] guix ui: add the "depends" field to package->recutils:
Mon, 21 Jul 2014 17:51:45 +0200
Gnus/5.130009 (Ma Gnus v0.9) Emacs/24.3 (gnu/linux)
Cyril Roelandt <address@hidden> skribis:
> * guix/packages.scm (package-direct-inputs): New procedure.
> * tests/packages.scm: Test it.
> * guix/ui.scm (package->recutils): Print the dependencies of the package.
OK! “ui:” is enough in the subject line.
> + (format port "depends: ~a~%"
> + (match (package-direct-inputs p)
> + (((labels packages) ...)
> + (string-join (map package-full-name (sort packages package<?)) ",
Please align “(match” with “port”.
Also, I think “dependencies” would be more consistent than “depends”
(sorry I didn’t catch it before.) Could you make that change?
OK to commit with these changes.