[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] Emacs interface for Guix

From: Alex Kost
Subject: [PATCH] Emacs interface for Guix
Date: Tue, 12 Aug 2014 14:19:48 +0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux)


Ludovic Courtès (2014-08-12 00:54 +0400) wrote:

> Alex Kost <address@hidden> skribis:
>> - A part of code for installing/upgrading/removing was extracted from
>>   ‘guix-package’ function (from ‘process-actions’ more precisely).  So
>>   the new function (I named it ‘process-package-actions’) can be used in
>>   "guix.el".
> That looks good, but could you make it a separate patch?
> In general, it’s better to send atomic changes, with a commit log, in
> the format produced by ‘git format-patch’ (see HACKING.)  That
> facilitates review and incremental changes.

Thanks for pointing.  I've never contributed to a real project, so I
don't know the rules actually :)

>> - A bit of code was placed into "profiles.scm" as ‘manifest-add’.
> Good idea.  Could you send a single patch for this change?  I’ll even
> add a couple of test cases in tests/profiles.scm for the new procedure
> if you don’t do it yourself.  :-)

Ok, I'm attaching 2 patches with ‘manifest-add’ and
‘process-package-actions’.  What should be changed/improved there?

Attachment: 0001-profiles-Add-manifest-add.patch
Description: Text Data

Attachment: 0002-guix-package-Add-process-package-actions.patch
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]