[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Emacs interface for Guix

From: Ludovic Courtès
Subject: Re: [PATCH] Emacs interface for Guix
Date: Sat, 16 Aug 2014 14:24:42 +0200
User-agent: Gnus/5.130011 (Ma Gnus v0.11) Emacs/24.3 (gnu/linux)

(Sorry for replying to messages in the wrong order.  :-))

Alex Kost <address@hidden> skribis:

> Ok, I'm attaching these patches.  But there are several issues there:
> - I fixed a typo in "tests/profiles.scm" (“profile” -> “profiles”) – Is
>   it ok to do this in that commit or should there be a separate commit?

No that’s OK.

> - I added a copyright line to the test file as well.  Is it ok?


> - The main thing: look at ‘manifest-show-transaction’ – unlike
>   ‘show-what-to-remove/install’ it doesn't display an output path of a
>   package item, because a store should be used for that.  So is it
>   acceptable or should something be changed there?

I think it should be changed to display the same thing as before.  What
about adding just a ‘store’ parameter to ‘manifest-show-transaction’,
and then just use the same code as ‘show-what-to-remove/install’?

Other than that the two patches look good, so if you make that change,
we can go ahead.

>>> Also I think "guix.el" should check for freshness too, so
>>> ‘check-package-freshness’ should probably be exported.
>> Yes, probably in the (gnu packages) module?
> Probably, but I think I'm not competent to decide :)

Well, take it as a suggestion then.  :-)


reply via email to

[Prev in Thread] Current Thread [Next in Thread]