[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] gnu: base: Add Glibc-Hurd Headers.

From: Ludovic Courtès
Subject: Re: [PATCH] gnu: base: Add Glibc-Hurd Headers.
Date: Fri, 29 Aug 2014 15:48:32 +0200
User-agent: Gnus/5.130011 (Ma Gnus v0.11) Emacs/24.3 (gnu/linux)

Hi, Manolis!

I have finally reviewed the 2 pending patches of yours that add
glibc-hurd and glibc-hurd-headers.  I’ve combined these 2 patches as
well as the hurd-minimal one into a single one to make a self-contained

I’ve then reviewed it, which led me to simplify a few things, and add a
bunch of FIXMEs, and pushed the result as the ‘wip-hurd’ branch.

Can you please check it out, look at all the FIXMEs, both in the .scm
and .patch files, address them, and post a patch here (no need for a
detailed commit log.)

The FIXMEs are about:

  • Things that are probably unneeded: if there are actually unneeded,
    please remove them, otherwise add a comment clearly stating why they
    are needed.

  • Workarounds that lack a justification, have an unclear
    justification, and/or lack a link to the relevant mailing list

If there is any FIXME that is unclear to you, please do let me know.

There are many workarounds being applied here, so it’s very important to
be rigorous in defining what they’re for so this can be maintained.

Also make sure that the result does not introduce any regressions with
the not-yet-reviewed cross-base.scm patch.

I think we’re on the right track now.  :-)

Thanks in advance, and again apologies for the looooong delay!


reply via email to

[Prev in Thread] Current Thread [Next in Thread]