[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] emacs: Add support for deleting generations.
|
From: |
Alex Kost |
|
Subject: |
Re: [PATCH] emacs: Add support for deleting generations. |
|
Date: |
Mon, 06 Oct 2014 00:04:07 +0400 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) |
Ludovic Courtès (2014-10-05 23:20 +0400) wrote:
> Alex Kost <address@hidden> skribis:
>
>> Thanks for the comments, the updated patch is attached. I also fixed
>> another “i.e.” thing there and used ‘with-store’ in
>> ‘process-package-actions’ procedure as well. Is it OK to make these
>> changes in this commit (the ‘with-store’ change is small but many lines
>> were changed because of the new indentation)?
>
> The ‘with-store’ change in ‘process-package-actions’ would be better in
> a separate patch, because it fixes an unrelated file descriptor leak.
>
> Other than that the patch looks good to me, thank you!
Pushed, thanks. Here is another patch for fixing ‘process-package-actions’.
0001-emacs-Use-with-store-in-process-package-actions.patch
Description: Text Data
[PATCH] guix package: Add '--switch-generation' option., Alex Kost, 2014/10/06
- Re: [PATCH] guix package: Add '--switch-generation' option., Ludovic Courtès, 2014/10/06
- Re: [PATCH] guix package: Add '--switch-generation' option., Alex Kost, 2014/10/07
- Re: [PATCH] guix package: Add '--switch-generation' option., Ludovic Courtès, 2014/10/07
- Re: [PATCH] guix package: Add '--switch-generation' option., Alex Kost, 2014/10/07
- Re: [PATCH] guix package: Add '--switch-generation' option., Ludovic Courtès, 2014/10/08
Re: [PATCH] guix package: Export generation procedures., Andreas Enge, 2014/10/05