Re: [PATCH 2/4] gnu: Add xcffib

[Federico Beffa]

On Mon, Dec 15, 2014 at 11:16 PM, Ludovic Courtès <address@hidden> wrote:
> Federico Beffa <address@hidden> skribis:
>
>> From f4187d31f95e3a65947d77bf267115906ed3816b Mon Sep 17 00:00:00 2001
>> From: Federico Beffa <address@hidden>
>> Date: Wed, 10 Dec 2014 20:36:58 +0100
>> Subject: [PATCH 2/4] gnu: Add xcffib
>>
>> * gnu/packages/python.scm (python-xcffib, python2-xcffib): New variables.
>
> [...]
>
>> +    (propagated-inputs
>> +     `(("python-cffi" ,python-cffi)))
>
> Please add a comment saying why this is propagated.
>
>> +    (synopsis "XCB Python binding")
>
> “bindings” (plural)
>
>> +    (description
>> +     "A drop in replacement for xpyb, an XCB python binding.")
>
> “drop-in”, “Python”, “bindings”.
>
> Could you expound the description a little bit?

Please find attached an updated patch. Regarding the description: I've
tried to expand it a little, but, to be honest, I do not know much
about this package. I copied the description from the web site. I only
packaged it because it is used by other packages I'm interested in :-)

Regards,
Fede

0002-gnu-Add-xcffib.patch
Description: Text Data