Re: [PATCH] gnu: Add bowtie.

[Ludovic Courtès]

Ricardo Wurmus <address@hidden> skribis:

> From 713bb1145ff901c4069f2fadb210d8eb842981da Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <address@hidden>
> Date: Tue, 16 Dec 2014 17:52:44 +0100
> Subject: [PATCH] gnu: Add bowtie
>
> * gnu/packages/bioinformatics.scm (bowtie): New variable.

[...]

> +        'patch-makefile
> +        (lambda _
> +          (substitute* "Makefile"
> +            (("^CC = .*$") (string-append "CC = " (which "gcc")))
> +            (("^CPP = .*$") (string-append "CPP = " (which "g++")))
> +            ;; replace BUILD_HOST and BUILD_TIME for deterministic build
> +            (("-DBUILD_HOST=.*") "-DBUILD_HOST=\"\\\"guix\\\"\"")
> +            (("-DBUILD_TIME=.*") "-DBUILD_TIME=\"\\\"0\\\"\"")))

Could you make this a ‘snippet’?  It suffices to write “CC = gcc” and
“CPP = g++”.  That way, running ‘guix build -S bowtie’ will return
source that’s closer to what we’re using.

> +    (license license:gpl3)))

>From a quick glance, this should be ‘gpl3+’ (source file headers carry
the “or any later version” phrase.)

Could you post an updated patch?

TIA,
Ludo’.