guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] gnu: Add tidy.


From: Mark H Weaver
Subject: Re: [PATCH] gnu: Add tidy.
Date: Sat, 07 Feb 2015 21:02:06 -0500
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4 (gnu/linux)

David Thompson <address@hidden> writes:

> +(define-public tidy
> +  (package
> +    (name "tidy")
> +    (version "20091223")
> +    (source (origin
> +              (method cvs-fetch)
> +              (uri (cvs-reference
> +                    (root-directory
> +                     ":pserver:address@hidden:/cvsroot/tidy")
> +                    (module "tidy")
> +                    (revision "2009-12-23")))
> +              (sha256
> +               (base32
> +                "14dsnmirjcrvwsffqp3as70qr6bbfaig2fv3zvs5g7005jrsbvpb"))))
> +    (build-system gnu-build-system)
> +    (arguments
> +     '(#:phases (alist-cons-before
> +                 'configure 'bootstrap

Please do (alist-cons-after 'unpack ...) instead.  The reason is that we
need this to happen before the 'patch-/usr/bin/file' phase and other
similar passes that fix up 'configure', otherwise things are likely to
break on MIPS and ARM.

Looks good to me otherwise.

     Thanks!
       Mark



reply via email to

[Prev in Thread] Current Thread [Next in Thread]