guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] packages: Add zip archive support to 'patch-and-repack'.


From: Ludovic Courtès
Subject: Re: [PATCH] packages: Add zip archive support to 'patch-and-repack'.
Date: Tue, 24 Mar 2015 21:50:19 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4 (gnu/linux)

Eric Bavier <address@hidden> skribis:

> * guix/packages.scm (%standard-patch-inputs): Add "unzip".
>   (patch-and-repack)[decompression-type]: Detect zip archive.
>   [build]: Invoke "unzip" when appropriate.

Please add “Fixes <http://bugs.gnu.org/19830>.” right above, and email
address@hidden with the commit id afterwards.

> -                   (zero? (system* (string-append #$tar "/bin/tar")
> -                                   "xvf" #$source)))
> +                   #$@(if (string=? decompression-type "unzip")
> +                          #~((zero? (system* "unzip" #$source)))
> +                          #~((zero? (system* (string-append #$tar "/bin/tar")
> +                                             "xvf" #$source)))))

Simply:

  #$(if (string=? decompression-type "unzip")
        #~(zero? (system* "unzip" #$source))
        #~(zero? (system* (string-append #$tar "/bin/tar") ...)))

OK to push with these changes!

Thank you,
Ludo’.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]