[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Add FASTX Toolkit.
From: |
Ricardo Wurmus |
Subject: |
Re: [PATCH] Add FASTX Toolkit. |
Date: |
Thu, 16 Apr 2015 10:31:25 +0200 |
Ludovic Courtès writes:
> Ricardo Wurmus <address@hidden> skribis:
>
>> "fastx-toolkit" installs three m4 files to "$out/share/aclocal", and
>> libgtextutils installs an empty "$out/share/aclocal" directoy. I
>> reported this upstream, but I did not add a phase to remove these files,
>> because I think it's not a big deal. Is this okay or should I modify
>> the sources to avoid installing these files?
>
> What’s wrong with these files? It looks fine to me, and it’s the
> standard directory for Autoconf macros. So no problem IMO. :-)
They are not necessary to use fastx-toolkit, so I'd rather avoid the
clutter. The author seems to agree and is willing to accept patches to
fix this.
>> + (home-page "http://hannonlab.cshl.edu/fastx_toolkit")
>
> Maybe the github.com URL?
Okay.
I pushed the two commits with the suggested changes. Thanks for the
review!
~~ Ricardo