[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/7] gnu: gobject-introspection: Update to 1.44.0.
From: |
Ludovic Courtès |
Subject: |
Re: [PATCH 1/7] gnu: gobject-introspection: Update to 1.44.0. |
Date: |
Tue, 21 Apr 2015 23:04:08 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Hi!
Note: this series should go to a ‘glib’ branch, which we’ll get Hydra to
build.
宋文武 <address@hidden> skribis:
> * gnu/packages/glib.scm (gobject-introspection): Update to 1.44.0.
> [source]: Use mirror://gnome.
> [arguments]<#:phases>: Remove.
> * gnu/packages/patches/gobject-introspection-cc.patch: Rewrite to
> set os.environ['CC'] in 'giscanner/__init__.py'.
I don’t know exactly what happened but something broke since the
original patch went in. The intent was described at
<https://lists.gnu.org/archive/html/guix-devel/2013-11/msg00127.html>.
> +Use gcc as the default C compiler if CC is not set.
> +
> +
> +--- gobject-introspection-1.44.0.orig/giscanner/__init__.py 2014-08-04
> 22:37:07.000000000 +0800
> ++++ gobject-introspection-1.44.0/giscanner/__init__.py 2015-04-20
> 17:30:26.507697234 +0800
> +@@ -22,3 +22,5 @@
> + builddir = os.environ.get('UNINSTALLED_INTROSPECTION_BUILDDIR')
> + if builddir is not None:
> + __path__.append(os.path.join(builddir, 'giscanner'))
> ++if not 'CC' in os.environ:
> ++ os.environ['CC'] = 'gcc'
Is it OK if $CC is set for all the child processes of giscanner?
Assuming there’s no issue in this area, that looks good to me. And
there’s a whole bunch of CC=gcc that you can remove afterwards. :-)
Thanks!
Ludo’.
- [PATCH 1/7] gnu: gobject-introspection: Update to 1.44.0., 宋文武, 2015/04/20
- [PATCH 2/7] gnu: itstool: Update to 2.0.2., 宋文武, 2015/04/20
- [PATCH 3/7] gnu: dbus-glib: Update to 0.104., 宋文武, 2015/04/20
- [PATCH 4/7] gnu: libsigc++: Update to 2.4.1., 宋文武, 2015/04/20
- [PATCH 5/7] gnu: glibmm: Update to 2.44.0., 宋文武, 2015/04/20
- [PATCH 6/7] gnu: python-pygobject: Update to 3.16.1., 宋文武, 2015/04/20
- [PATCH 7/7] gnu: poppler: Update to 0.32.0., 宋文武, 2015/04/20
- Re: [PATCH 1/7] gnu: gobject-introspection: Update to 1.44.0.,
Ludovic Courtès <=
- Re: [PATCH 1/7] gnu: gobject-introspection: Update to 1.44.0., Ludovic Courtès, 2015/04/21
- Re: [PATCH 1/7] gnu: gobject-introspection: Update to 1.44.0., Andreas Enge, 2015/04/21
- Re: [PATCH 1/7] gnu: gobject-introspection: Update to 1.44.0., Mark H Weaver, 2015/04/21
- Re: [PATCH 1/7] gnu: gobject-introspection: Update to 1.44.0., 宋文武, 2015/04/21
- Re: [PATCH 1/7] gnu: gobject-introspection: Update to 1.44.0., Andreas Enge, 2015/04/22
- Re: [PATCH 1/7] gnu: gobject-introspection: Update to 1.44.0., Mark H Weaver, 2015/04/22
- Re: [PATCH 1/7] gnu: gobject-introspection: Update to 1.44.0., Andreas Enge, 2015/04/22
- Re: [PATCH 1/7] gnu: gobject-introspection: Update to 1.44.0., Ludovic Courtès, 2015/04/22
- Re: [PATCH 1/7] gnu: gobject-introspection: Update to 1.44.0., Mark H Weaver, 2015/04/22