[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] gnu: Add sfxr.
From: |
Mark H Weaver |
Subject: |
Re: [PATCH] gnu: Add sfxr. |
Date: |
Tue, 19 May 2015 18:23:05 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Hi David,
David Thompson <address@hidden> writes:
> From af67dcbcee6dfe218e8f3080551a213b5cc8eebd Mon Sep 17 00:00:00 2001
> From: David Thompson <address@hidden>
> Date: Mon, 18 May 2015 19:14:01 -0400
> Subject: [PATCH] gnu: Add sfxr.
>
> * gnu/packages/game-development.scm (sfxr): New variable.
> ---
> gnu/packages/game-development.scm | 42
> ++++++++++++++++++++++++++++++++++++++-
> 1 file changed, 41 insertions(+), 1 deletion(-)
>
>
> diff --git a/gnu/packages/game-development.scm
> b/gnu/packages/game-development.scm
> index 2191767..5941344 100644
> --- a/gnu/packages/game-development.scm
> +++ b/gnu/packages/game-development.scm
> @@ -33,7 +33,11 @@
> #:use-module (gnu packages fontutils)
> #:use-module (gnu packages image)
> #:use-module (gnu packages audio)
> - #:use-module (gnu packages pulseaudio))
> + #:use-module (gnu packages pulseaudio)
> + #:use-module (gnu packages gnome)
> + #:use-module (gnu packages gtk)
> + #:use-module (gnu packages sdl)
> + #:use-module (gnu packages pkg-config))
>
> (define-public bullet
> (package
> @@ -127,3 +131,39 @@ clone.")
> to ease the development of games and multimedia applications. It is composed
> of five modules: system, window, graphics, audio and network.")
> (license license:zlib)))
> +
> +(define-public sfxr
> + (package
> + (name "sfxr")
> + (version "1.2.1")
> + (source (origin
> + (method url-fetch)
> + (uri (string-append
> "http://www.drpetter.se/files/sfxr-sdl-1.2.1.tar.gz"))
> + (sha256
> + (base32
> + "0dfqgid6wzzyyhc0ha94prxax59wx79hqr25r6if6by9cj4vx4ya"))))
> + (build-system gnu-build-system)
> + (arguments
> + `(#:phases (modify-phases %standard-phases
> + (delete 'configure) ; no configure script
> + (add-before 'build 'patch-makefile
> + (lambda* (#:key outputs #:allow-other-keys)
> + (let ((out (assoc-ref outputs "out")))
> + (substitute* "Makefile"
> + (("\\$\\(DESTDIR\\)/usr") out))
> + (substitute* "main.cpp"
> + (("/usr/share")
> + (string-append out "/share")))))))
Please add #t to the end of this phase procedure, since the return value
of 'substitute*' is not specified, and phase procedures are supposed to
return a boolean indicating success or failure.
Otherwise, it looks good to me!
Thanks,
Mark