Re: [PATCH] Propagate input for JACK; fix portaudio JACK-support

[Ludovic Courtès]

Ricardo Wurmus <address@hidden> skribis:

> while packaging Extempora I noticed that the portaudio does not seem to
> work with JACK.  Extempora uses portaudio and it would not create a JACK
> port.
>
> After I rebuilt portaudio with “jack-1” rather than “jack-2” Extempora
> would create a JACK port via portaudio successfully.  “jack-1” had to be
> modified to propagate “bdb” because the libjack headers include it.
>
> Attached are these two patches.

Makes sense.

> In general I would suggest only to use “jack-1” as an input.  “jack-2”
> is a different implementation, but it does not replace “jack-1”.
> For a user it may make sense to install “jack-2” because of DBus
> support, but for libraries it should not be needed.

OK.

> From 579dcf04e35a093ca6bb97efff5aaec19053c080 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <address@hidden>
> Date: Sat, 18 Jul 2015 22:07:45 +0200
> Subject: [PATCH 1/2] gnu: jack-1: Propagate "bdb".
>
> * gnu/packages/audio.scm (jack-1)[inputs]: Move "bdb" from here...
>    [propagated-inputs]: ...to here.

LGTM.

> From 4238c7742fef8e7786569beefe79ca9188b50e8e Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <address@hidden>
> Date: Sat, 18 Jul 2015 22:09:13 +0200
> Subject: [PATCH 2/2] gnu: portaudio: Build with jack-1.
>
> * gnu/packages/audio.scm (portaudio)[inputs]: Replace "jack-2" with "jack-1".

LGTM.  Perhaps a comment should be added next to this package or next to
‘jack-2’ to explain what you wrote above?

Thanks,
Ludo’.