[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/4] build: Produce 'guix-config' instead of using compile-ti
From: |
Mathieu Lirzin |
Subject: |
Re: [PATCH 2/4] build: Produce 'guix-config' instead of using compile-time tricks. |
Date: |
Thu, 06 Aug 2015 19:50:36 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Alex Kost <address@hidden> writes:
> Mathieu Lirzin (2015-07-28 00:48 +0300) wrote:
>
> [...]
>> +(defconst guix-prefix
>> + "@prefix@")
>> +
>> +(defconst guix-emacs-ui-dir
>> + "@emacsuidir@")
>
> I think this constant is useless in this form since its value will be
> "${prefix}/share/guile/site/2.0/guix/emacs". What about making it:
>
> (defconst guix-emacs-ui-dir
> (replace-regexp-in-string "${prefix}" guix-prefix "@emacsuidir@"))
>
That makes sense. I have gone further in the way of what you suggested,
by mimicking what has been done in "guix/config.scm".
> And to leave:
>
> (defvar guix-load-path guix-emacs-ui-dir
> "Directory with scheme files for \"guix.el\" package.")
>
> in "guix-backend.el"?
I would prefer to keep this change separated. See last updated patch of
this batch.
--
Mathieu Lirzin
0001-build-Produce-guix-config-instead-of-using-compile-t.patch
Description: Text Data
- Re: [PATCH 2/4] build: Produce 'guix-config' instead of using compile-time tricks.,
Mathieu Lirzin <=