Re: [PATCH 6/7] gnu: Add libconfuse.

[Eric Bavier]

On Mon, 17 Aug 2015 05:05:36 +0200
Eric Dvorsak <address@hidden> wrote:

> * gnu/packages/i3.scm (libconfuse): New variable.
> ---
>  gnu/packages/i3.scm | 22 ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)
> 
> diff --git a/gnu/packages/i3.scm b/gnu/packages/i3.scm
> index bcb4888..725fdb6 100644
> --- a/gnu/packages/i3.scm
> +++ b/gnu/packages/i3.scm
> @@ -39,6 +39,28 @@
>    #:use-module (guix download)
>    #:use-module (guix git-download))
>  
> +(define-public libconfuse
> +  (package
> +    (name "libconfuse")
> +    (version "2.7")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append 
> "http://savannah.nongnu.org/download/confuse/";
> +                                  "confuse-" version ".tar.gz"))
> +              (sha256
> +               (base32
> +
> "0y47r2ashz44wvnxdb18ivpmj8nxhw3y9bf7v9w0g5byhgyp89g3"))))
> +    (build-system gnu-build-system)
> +    (home-page "http://www.nongnu.org/confuse/";)
> +    (synopsis "Configuration file parser library")
> +    (description "A configuration file parser library. It supports

"libconfuse is a configuration..."

Also, two spaces at the end of sentences.  'guix lint libconfuse'
should warn about this.

> +sections and (lists of) values (strings, integers, floats, booleans
> or +other sections), as well as some other features (such as
> +single/double-quoted strings, environment variable expansion,
> +functions and nested include statements).  It makes it very easy to
> +add configuration file capability to a program using a simple API. ")

"very easy" and "simple" seem too much like advertising.  Perhaps the
last sentence could be left out to keep the description more neutral.
WDYT?

Otherwise LGTM.

`~Eric