[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] gnu: Add cabal-install.
From: |
Siniša Biđin |
Subject: |
Re: [PATCH] gnu: Add cabal-install. |
Date: |
Wed, 26 Aug 2015 05:59:51 +0200 |
On 2015-08-25 23:27, address@hidden wrote:
Please add a copyright line for yourself.
Added.
+ (arguments `(#:tests? #f))
Could you add a comment above explaining why tests are disabled? (We
generally avoid that unless there’s a good reason, sometimes because
running the tests would be unnecessarily complex.)
I've added a simple "FIXME" comment to that line, similar to how the
other haskell.scm packages do it. The reason is that the ghc-* libs
needed to enable testing haven't been imported yet. I've attempted to
fix that, but got tangled up in conflicting dependency versions and
gave up for now.
+ (synopsis "The command-line interface for Cabal and Hackage.")
Remove “The” and the period (and make sure to run ‘guix lint’ ;-)).
Also fixed.
Could you send an updated patch?
Sure, you'll find it attached.
Thanks,
Siniša
0001-gnu-Add-cabal-install.patch
Description: Text Data