[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] system: grub: Adjust eye-candy to work on non-Intel systems
From: |
Ludovic Courtès |
Subject: |
Re: [PATCH] system: grub: Adjust eye-candy to work on non-Intel systems |
Date: |
Thu, 27 Aug 2015 23:25:11 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Mark H Weaver <address@hidden> skribis:
> This patch adjusts the 'eye-candy' portion of our GRUB configuration to
> work properly on non-Intel systems, and specially on Loongson machines.
It effectively disables eye candy on non-Intel, no? Or is it just that
those GRUB modules are not needed there?
> From 943a4a9e30e1e659a6e1591e965d215bf8e8f351 Mon Sep 17 00:00:00 2001
> From: Mark H Weaver <address@hidden>
> Date: Sun, 9 Aug 2015 18:45:49 -0400
> Subject: [PATCH] system: grub: Adjust eye-candy to work on non-Intel systems.
>
> * gnu/system/grub.scm (eye-candy): Accept additional 'system' argument. Add
> local 'intel?' variable. Replace the 'load_video' grub function with
> 'setup_gfxterm', which includes everything in the 'if loadfont' form on
> Intel systems, but is empty on non-Intel.
> (grub-configuration-file): Pass 'system' to 'eye-candy.
[...]
> + (return (and image
> + #~(let ((setup-gfxterm-body
> + (if #$intel?
Maybe just add a comment explicitly stating that on Loongson nothing
special is needed.
Otherwise LGTM, thanks!
Ludo’.