[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Add ibus-libpinyin.
From: |
Ludovic Courtès |
Subject: |
Re: [PATCH] Add ibus-libpinyin. |
Date: |
Wed, 09 Sep 2015 22:07:09 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Ricardo Wurmus <address@hidden> skribis:
> From 984245dcc1359c4de3ff3a26c0d1d6427a88b6fa Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <address@hidden>
> Date: Wed, 9 Sep 2015 07:27:18 +0200
> Subject: [PATCH 1/2] gnu: Add libpinyin.
>
> * gnu/packages/ibus.scm (libpinyin): New variable.
[...]
> + ,(origin
> + (method url-fetch)
> + (uri (string-append "http://downloads.sourceforge.net/libpinyin/"
> + "models/model10.text.tar.gz"))
Should be mirror://sourceforge/ if possible.
> + (native-inputs
> + `(("pkg-config" ,pkg-config)
> + ("tar" ,tar)
‘tar’ can be omitted, it’s an implicit input.
Otherwise OK.
> From d474729c8f8951e2c7e45cc7dba1b1542ab0e5a8 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <address@hidden>
> Date: Wed, 9 Sep 2015 07:28:23 +0200
> Subject: [PATCH 2/2] gnu: Add ibus-libpinyin.
>
> * gnu/packages/ibus.scm (ibus-libpinyin): New variable.
LGTM.
It’s a pity that no ‘make dist’ tarball is published; that would make
everbody’s lives easier.
Thanks,
Ludo’.