[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 01/19] gnu: Add r-assertthat.
From: |
Vicente Vera |
Subject: |
Re: [PATCH 01/19] gnu: Add r-assertthat. |
Date: |
Tue, 15 Sep 2015 14:32:38 -0300 |
Updated patch attached.
2015-09-13 19:20 GMT-03:00 Vicente Vera <address@hidden>:
> Hi Ricardo,
>
> CRAN importer? Hmm, just made a very useful discovery! I feel ashamed now.
>
> Attached goes the 1st patch with the modified copyright header and the
> fixed typo (actually, it came with the package description in CRAN).
>
>
> 2015-09-13 17:04 GMT-03:00 Ricardo Wurmus <address@hidden>:
>> Thank you very much for these patches! Did you use the CRAN importer
>> for them?
>>
>> You should add your name to the copyright header at the top of the file
>> (maybe as part of the first patch).
>>
>>> * gnu/packages/statistics.scm (r-assertthat): New variable.
>>
>> [...]
>>
>>> + (uri (string-append "mirror://cran/src/contrib/assertthat_"
>>> + version ".tar.gz"))
>>
>> I wonder if new patches should already contain the archive URI in
>> addition to the default URI. It was pointed out in a previous thread
>> that the simple URI produced by the importer is only valid for the
>> latest version.
>>
>>> + (description
>>> + "Assertthat is an extension to stopifnot() that makes it easy to
>>> +declare the pre and post conditions that you code should satisfy,
>>
>> s/you code/your code/
>>
>>> +while also producing friendly error messages so that your users know
>>> +what they've done wrong.")
>>
>> ~~ Ricardo
>>
0001-gnu-Add-r-assertthat.patch
Description: Text Data