Re: [PATCH 0/2] Add sxhkd and bspwm.

[Alex Kost]

xd1le (2015-10-10 14:06 +0300) wrote:

>> Also was it intended to use "rws" as the Author name?  If not, then
>> please configure your git to use a name you want.
>
> Well yes, I don't want to use my real name. I changed it my irc nick, is that
> okay?

Okay for me, but I don't know what the others think, as you will be the
first, who would like to use just a nickname.

>> Unlike the previous package, here it should be (license license:bsd-2).
>> As you can see in (gnu packages xdisorg), (guix licenses) module is used
>> with "#:prefix license:".
>
> So what's the purpose of the prefix? (Just to learn.)

To avoid conflicts.  For example, both (gnu packages compression) and
(guix licenses) modules export 'zlib' variables, so we need to
distinguish them somehow.  That's why there is a prefix: just 'zlib'
means a package and 'license:zlib' means a license.

[...]
>   gnu: sxhkd: New variable.
>   gnu: bspwm: New variable.

Sorry, I didn't mean that the first lines should also be changed.  So a
full commit message would be:

--8<---------------cut here---------------start------------->8---
gnu: Add sxhkd.

* gnu/packages/xdisorg.scm (sxhkd): New variable.
--8<---------------cut here---------------end--------------->8---

No need to resend the patches, I will fix it and push soon if there will
be no other comments.

-- 
Alex