guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/3] emacs: Enable 'guix-build-log-mode' for build log files.


From: Ludovic Courtès
Subject: Re: [PATCH 1/3] emacs: Enable 'guix-build-log-mode' for build log files.
Date: Sun, 01 Nov 2015 18:20:59 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)

Alex Kost <address@hidden> skribis:

> From 11fea59d41063b3511a84a0d783cfa2016ed68c4 Mon Sep 17 00:00:00 2001
> From: Alex Kost <address@hidden>
> Date: Sat, 31 Oct 2015 21:36:41 +0300
> Subject: [PATCH 1/2] emacs: Add 'guix-hash-char-regexp'.
>
> * emacs/guix-utils.el (guix-hash-char-regexp): New constant.
> * emacs/guix-prettify.el (guix-prettify-regexp): Use it.

LGTM.  The only possible downside is if it noticeably slows things down,
which may be the case.  Have you seen any difference?

If it happens to be slower, I’m fine with the current (sloppier)
variant.

> From a9a1b1ef7c272a188745d367745f9ef4fc155be9 Mon Sep 17 00:00:00 2001
> From: Alex Kost <address@hidden>
> Date: Thu, 29 Oct 2015 20:48:53 +0300
> Subject: [PATCH 2/2] emacs: Enable 'guix-build-log-mode' for build log files.
>
> * emacs/guix-build-log.el (auto-mode-alist): Add 'guix-build-log-mode'
>   to 'auto-mode-alist'.

LGTM, thanks!

Ludo’.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]