Re: [PATCH 2/2] gnu: Add owncloud-client.

[Ludovic Courtès]

Efraim Flashner <address@hidden> skribis:

> * gnu/packages/owncloud.scm (owncloud-client): New variable.
> * gnu-system.am [GNU_SYSTEM_MODULES]: Add it.

[...]

> +       (modify-phases %standard-phases
> +        (add-after 'unpack 'change-rpath-dirs
> +          (lambda _
> +           (substitute* '("src/libsync/CMakeLists.txt"
> +                          "csync/src/CMakeLists.txt")
> +                         (("\\/\\$\\{APPLICATION_EXECUTABLE\\}") ""))
> +           (substitute* '("src/cmd/CMakeLists.txt"
> +                          "src/crashreporter/CMakeLists.txt"
> +                          "src/gui/CMakeLists.txt")
> +                         (("\\/\\$\\{APPLICATION_EXECUTABLE\\}\\\"") 
> "\"")))))))

Please indent as in other files.  Also, could you add a comment
explaining what this does?

> +    (synopsis "GUI folder synchronization with an ownCloud server")

I’d remove “GUI” here (looks weird.)

> +    (description "The ownCloudSync system lets you always have your latest

… and s/system/GUI/ here.

Could you send an updated patch?

Thanks,
Ludo’.